Repository navigation
Conversation
`--workspaces=false` walked root edges and read `edge.to.isWorkspace` without guarding a missing dependency (`edge.to === null`), which threw TypeError. Skip only when the edge actually resolves to a workspace. Fixes npm#10157
CI eslint no-multiple-empty-lines failed on the --no-workspaces regression test block.
Contributor
Author
|
CI Lint failed on Pushed a one-line follow-up that removes the duplicate blank. Tests were already green; this is lint-only. |
jeffkl
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #10157
npm ls --workspaces=falsecrashed withCannot read properties of null (reading 'isWorkspace')whenever a root dependency was missing or omitted. The workspaces filter readedge.to.isWorkspacewithout checking thatedge.toexists (unmet deps use a null target).Changes
edge.tobeforeisWorkspaceinfilterBySelectedWorkspaces.--workspaces=falserejects withELSPROBLEMSinstead of TypeError.Test plan
tap test/lib/commands/ls.js --grep 'issue 10157' --no-coveragenpm ls --workspaces=false --depth=0exitsELSPROBLEMS, no TypeErrorAI disclosure
Prepared with AI assistance (Grok Bot). Changes and tests reviewed before submit.