Repository navigation
INIT_CLASS_ENTRY should use strlen() to determine class name length #10217
Description
Description
This works:
INIT_CLASS_ENTRY(ce, "mylongclassname", methods);This does not:
void register_class(zend_class_entry * ce, const char * name, const zend_function_entry * methods) {
INIT_CLASS_ENTRY(ce, name, methods);
}
register_class(ce, "mylongclassname", methods);Because INIT_OVERLOADED_CLASS_ENTRY uses sizeof() to determine class_name_len:
#define INIT_OVERLOADED_CLASS_ENTRY(class_container, class_name, functions, handle_fcall, handle_propget, handle_propset) \
INIT_OVERLOADED_CLASS_ENTRY_EX(class_container, class_name, sizeof(class_name)-1, functions, handle_fcall, handle_propget, handle_propset, NULL, NULLPHP Version
All
Operating System
All
Activity
[-]INIT_OVERLOADED_CLASS_ENTRY uses sizeof() to determine class name length[/-][+]INIT_CLASS_ENTRY uses sizeof() to determine class name length[/+]cmb69 commentedon Jan 4, 2023
I don't understand why this would be a bug. Are you writing a PHP extension? If so, you can use
INIT_CLASS_ENTRY_EX()in the first place, if you are not passing a constant asclass.cmb69 commentedon Jan 4, 2023
Ugh, that's a tough requirement.
Anyhow, I think we can change
INIT_OVERLOADED_CLASS_ENTRYand maybe some others to no longer usesizeof, but ratherstrlen()instead, but not everybody may like that (see #8336).Girgias commentedon Jan 4, 2023
I think for stuff like this which may be used by extensions it makes sense to proceed with those changes compared to changing all possible instances within bundled extensions
cmb69 commentedon Jan 5, 2023
@dbuteyn, maybe you want to provide a respective PR?
cmb69 commentedon Jan 5, 2023
Yeah, I don't think
sizeofhas been used for any other purpose than having the optimization (old compilers may not have optimizedstrlen()).[-]INIT_CLASS_ENTRY uses sizeof() to determine class name length[/-][+]INIT_CLASS_ENTRY should use strlen() to determine class name length[/+]Close phpGH-10217: Use strlen() for determining the class_name length