DateTimeZone fails to parse time zones that contain the "+" character #10218

Activity

1. spideyfusion

   added

   Bug

   Status: Needs Triage

   on Jan 4, 2023
2. heiglandreas commented on Jan 4, 2023

   

   heiglandreas

   on Jan 4, 2023

   Contributor

   More actions

   As per https://www.php.net/manual/en/timezones.others.php this can be expected behaviour as you should not use those! Depending on the implemented timezone-db this can break.

   👍React with 👍1Reacted by Christoph M. Becker
3. cmb69 commented on Jan 4, 2023

   

   cmb69

   on Jan 4, 2023

   Member

   More actions

   This behavioral change has likely been introduced by fixing #9700.
4. cmb69

   added

   Extension: date

   on Jan 4, 2023
5. cmb69

   assigned

   derickr

   on Jan 4, 2023
6. derickr

   added

   Status: Verified

   and removed

   Status: Needs Triage

   on Jan 5, 2023
7. hormus commented on Jan 5, 2023

   

   hormus

   on Jan 5, 2023

   Last edited by hormus

   More actions

   i'm in favor of reverting to previous code, user side it's easy to interpret even if you use convert it's good for 3rd party code

   <?php
   
   $date = date_create();
   $date = date_create('1970-01-01 00:00:00 +' . date_format($date, 'U') . 'sec', timezone_open('UTC'));
   $usercode_tz = timezone_open('Etc/GMT+1'); // UTC-1
   date_timezone_set($date, $usercode_tz);
   $date_display = date_format($date, 'Y-m-d\\TH:i:s e');
   $user_display = str_replace(' ', ' [', $date_display) . ']';
   $convert_user_display = str_replace(array(' [', ']'), '', $user_display);
   var_dump($convert_user_display);
   ?>
8. kalenjohnson commented on Jan 6, 2023

   

   kalenjohnson

   on Jan 6, 2023

   More actions

   Looks like this also affects 8.1.14

   👍React with 👍2Reacted by Aleksandar Puharic and Michiel van den Anker
9. xZero707 commented on Jan 10, 2023

   

   xZero707

   on Jan 10, 2023

   Last edited by xZero707

   More actions

   Can confirm this issue affects >= 8.1.14 and is not present in versions bellow.
   Running code from first example:

   Docker - 8.1.13

   /app/test.php:2:
   class DateTime#1 (3) {
     public $date =>
     string(26) "2023-01-10 08:15:09.977455"
     public $timezone_type =>
     int(3)
     public $timezone =>
     string(9) "Etc/GMT+1"
   }
   

   Docker - 8.1.14

   Fatal error: Uncaught Exception: DateTimeZone::__construct(): Unknown or bad timezone (Etc/GMT+1) in /app/test.php:2
   Stack trace:
   #0 /app/test.php(2): DateTimeZone->__construct('Etc/GMT+1')
   #1 {main}
     thrown in /app/test.php on line 2
   
10. derickr

    added a commit that references this issue on Jan 10, 2023

    Fixed GH-10218: DateTimeZone fails to parse time zones that contain t…

    ...

    This issue will close once commit d12ba11 is merged into the 'master' branch.

    d12ba11
11. derickr

    closed this as completedin d12ba11on Jan 10, 2023
12. SaSu-CLARK

    added 2 commits that reference this issue on Jan 18, 2023

    DEV-65163 mark tests as skipped due to php src error, see php/php-src…

    ...

    fb371f4

    DEV-65163 mark tests as skipped due to php src error, see php/php-src…

    ...

    553078e