Repository navigation
cli/get_set_process_title fails on MacOS #11246
Description
Description
The following code:
<?php
if (cli_set_process_title("title") === true &&
cli_get_process_title() === "title")
echo "Successfully set title\n";Resulted in this output:
PHP Warning: cli_set_process_title(): cli_set_process_title had an error: Not initialized correctly
PHP Warning: cli_get_process_title(): cli_get_process_title had an error: Not initialized correctly
But I expected this output instead:
Successfully set title
What was strange with this one it works from bash shells within PHPStorm, but fails on subprocesses (proc_open) or when php cli run from Terminal.
Tracing the issue finds that there may not be a contiguous environ strings following argv, however comparing to the original postgres version and checking the existing source this doesn't appear to be necessary to fail at this point.
I'll raise a PR shortly
PHP Version
PHP 8.1, PHP8.2
Operating System
MacOS
Activity
Fix bug phpGH-11246 cli/get_set_process_title
Fix bug phpGH-11246 cli/get_set_process_title initialisation failure …
lucasnetau commentedon May 31, 2023
Is there anyone who can triage this? 2 PRs have been submitted for PHP8.1 (#11247), and PHP8.2 (#11273).
I find projects that have patched over this by just ignoring Darwin based OS for example Synfony Console symfony/symfony#21076
iluuu1994 commentedon May 31, 2023
@lucasnetau I have an old Mac and so I'll have a look today.
lucasnetau commentedon May 31, 2023
Thank you. I only have macOS 13.3 boxes around but I replicated on both Intel and M1. The target version in CI is only 11 for macOS.
Fix bug GH-11246 cli/get_set_process_title
Merge branch 'PHP-8.1' into PHP-8.2
Merge branch 'PHP-8.2'
iluuu1994 commentedon May 31, 2023
Fixed in c6ae7a5.