You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
sqlite3_defensive.phpt fails with sqlite 3.44.0 #12633
The ext/sqlite3/tests/sqlite3_defensive.phpt test started to fail after upgrade of SQLite to 3.44.0 on all arches
Resulted in this output:
TEST 12220/16282 [ext/sqlite3/tests/sqlite3_defensive.phpt]
========DIFF========
bool(true)
003+ int(0)
int(1)
004- int(1)
Warning: SQLite3::querySingle(): Unable to prepare statement: 1, table sqlite_master may not be modified in %s on line %d
bool(false)
Probably due to this change. It looks like the test needs to be modified.
The SQLITE_DBCONFIG_DEFENSIVE setting now prevents PRAGMA writable_schema from being turned on. Previously writable_schema could be turned on, but would not actually allow the schema to be writable. Now it simply cannot be turned on.
Activity
SakiTakamachi commentedon Nov 8, 2023
I'll see this later.
SakiTakamachi commentedon Nov 8, 2023
Probably due to this change. It looks like the test needs to be modified.
https://www.sqlite.org/releaselog/3_44_0.html
Fix GH-12633: sqlite3_defensive.phpt fails with sqlite 3.44.0
Merge branch 'PHP-8.1' into PHP-8.2
Merge branch 'PHP-8.2' into PHP-8.3
Merge branch 'PHP-8.3'