MEMORY_LEAK in phpdbg_prompt.c

Description

Dynamic memory, referenced by res, is allocated at phpdbg_utils.c:154 :

Lines 146 to 155 in cde956a

    
           PHPDBG_API char *phpdbg_resolve_path(const char *path) /* {{{ */ 
        
           { 
        
           	char resolved_name[MAXPATHLEN]; 
        
           	if (expand_filepath(path, resolved_name) == NULL) { 
        
           		return NULL; 
        
           	} 
        
           	return strdup(resolved_name); 
        
           } /* }}} */

by calling function phpdbg_resolve_path at phpdbg_prompt.c:405 and lost at phpdbg_prompt.c:411 :

php-src/sapi/phpdbg/phpdbg_prompt.c

Lines 405 to 412 in cde956a

    
           char *res = phpdbg_resolve_path(param->str); 
        
           size_t res_len = strlen(res); 
        
           if ((res_len != PHPDBG_G(exec_len)) || (memcmp(res, PHPDBG_G(exec), res_len) != SUCCESS)) { 
        
           	if (PHPDBG_G(in_execution)) { 
        
           		if (phpdbg_ask_user_permission("Do you really want to stop execution to set a new execution context?") == FAILURE) { 
        
           			return FAILURE; 
        
           		}

The allocated memory will be lost even if the condition at phpdbg_prompt.c:408 is false.

Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.

Author E. Bykhanova.

PHP Version

PHP 8.2.3

Operating System

ALT Linux

There's even a second one in the Execution context not changed path. I'll get to it.
Thanks for reporting!

Fix phpGH-12675: MEMORY_LEAK in phpdbg_prompt.c

Fix GH-12675: MEMORY_LEAK in phpdbg_prompt.c

Merge branch 'PHP-8.2' into PHP-8.3

Merge branch 'PHP-8.3'

Fix GH-12675: MEMORY_LEAK in phpdbg_prompt.c

Navigation Menu

Repository navigation

MEMORY_LEAK in phpdbg_prompt.c #12675

Description

PHP Version

Operating System

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	PHPDBG_API char phpdbg_resolve_path(const char path) /* {{{ */
	{
	char resolved_name[MAXPATHLEN];

	if (expand_filepath(path, resolved_name) == NULL) {
	return NULL;
	}

	return strdup(resolved_name);
	} /* }}} */

	char *res = phpdbg_resolve_path(param->str);
	size_t res_len = strlen(res);

	if ((res_len != PHPDBG_G(exec_len)) \|\| (memcmp(res, PHPDBG_G(exec), res_len) != SUCCESS)) {
	if (PHPDBG_G(in_execution)) {
	if (phpdbg_ask_user_permission("Do you really want to stop execution to set a new execution context?") == FAILURE) {
	return FAILURE;
	}

MEMORY_LEAK in phpdbg_prompt.c #12675

Description

Description

PHP Version

Operating System

Activity

ndossche commented on Nov 15, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions