Repository navigation
SimpleXMLElement with stream_wrapper_register can segfault #12929
Description
Description
repro: https://3v4l.org/sR5ZB
inspired by #12926 and https://github.com/php/php-src/pull/12546/files
SimpleXMLIterator , have the same issueSodiumException, IntlChar
because of https://github.com/php/php-src/blob/php-8.3.0/run-tests.php#L2077 the run-tests.php test should be improved to allow to specify something like * in EXTENSIONS section, as currently the https://github.com/php/php-src/pull/12546/files is not really tested with all ext
PHP Version
8.1.0 - 8.1.7, 8.3.0
Operating System
any
Activity
ndossche commentedon Dec 11, 2023
Can confirm, at least for SimpleXML it's because in 8.3 I added the invalidation code which accesses
node->docbut apparentlynodecan be NULL afterGET_NODEbecause that macro doesn't perform the return...The locations of
GET_NODEhave to be checked on 8.2+.ndossche commentedon Dec 12, 2023
I can't reproduce it for these two classes though, not on my local machine and not in 3v4l...
Anyway PR is up to fix SimpleXML.
mvorisek commentedon Dec 12, 2023
3v4l repro: https://3v4l.org/pDpKO
ndossche commentedon Dec 12, 2023
But that doesn't segfault/crash right? https://3v4l.org/shafO I added a var_dump at the end and it prints, I don't see a code 139.
mvorisek commentedon Dec 12, 2023
I can confirm this is present for the XML classes only, at least today :)
Fix GH-12929: SimpleXMLElement with stream_wrapper_register can segfault
Merge branch 'PHP-8.3'