Repository navigation
Test curl_basic_024 fails with curl 8.8.0 #14307
Description
Description
After building PHP 8.3.7 on Chimera Linux and run test suite there is one test failing:
ext/curl/tests/curl_basic_024.phpt
Here is the log:
---- EXPECTED OUTPUT
bool(true)
bool(true)
string(4) "HTTP"
---- ACTUAL OUTPUT
bool(true)
bool(true)
string(4) "http"
---- FAILED
This test was passing without problems with older curl versions.
PHP Version
PHP 8.3.7
Operating System
Chimera linux
Activity
ndossche commentedon May 23, 2024
I can reproduce this. The data comes straight out of curl so I think we should simply update the test to tolerate both forms.
Fix phpGH-14307: Test curl_basic_024 fails with curl 8.8.0
lucasnetau commentedon May 24, 2024
There was a change done to Curl two weeks ago to lower case scheme
lib: make protocol handlers store scheme name lowercase curl/curl@c294f9c
CURLINFO_SCHEME documentation now notes
ndossche commentedon May 24, 2024
Thanks for the link @lucasnetau !
I'll include it in the commit's description.
Fix GH-14307: Test curl_basic_024 fails with curl 8.8.0
Merge branch 'PHP-8.2' into PHP-8.3
Merge branch 'PHP-8.3'
Fix phpGH-14307: Test curl_basic_024 fails with curl 8.8.0
Backport CI fixes to security branches