Repository navigation
Signed integer overflow in ext/date/php_date.c #14709
Description
Description
The following code:
<?php
define("MAX_64Bit", 9223372036854775807);
define("MAX_32Bit", 2147483647);
$otherVals = array(0, 1, -1, 7, 9, 65, -44, MAX_32Bit, MAX_64Bit);
foreach ($otherVals as $otherVal) {
foreach($longVals as $longVal) {
}
}
$script1_dataflow = $otherVal;
$start = new DateTime('2018-12-31 00:00:00');
$interval = new DateInterval('P1M');
$period = new DatePeriod($start, $interval, $script1_dataflow);Resulted in this output:
/php-src/ext/date/php_date.c:5113:35: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /php-src/ext/date/php_date.c:5113:35
PHP Version
PHP 8.4.0-dev
Operating System
ubuntu 22.04
Activity
cmb69 commentedon Dec 3, 2024
@devnexen, I just had a look at devnexen@dfa93a3 and this looks quite good (recurrences should probably less than INT_MAX-2, to cater to the possible additions). Are you planning to submit a PR?
devnexen commentedon Dec 3, 2024
AFAIK I probably already created a PR, just forgot to attach it.
#14710
Fix phpGH-14709 overflow on recurrences for DatePeriod::__construct
Fix GH-14709 overflow on recurrences for DatePeriod::__construct