Repository navigation
IntlChar::foldCase()'s $option is not optional #15087
Description
The method signature designates the options parameter as optional with the constant IntlChar::FOLD_CASE_DEFAULT as default. I am expecting the string(1) "i" when calling var_dump(IntlChar::foldCase("I"), but I get an error:
Fatal error: Uncaught ArgumentCountError: IntlChar::foldCase() expects exactly 2 arguments, 1 given
<?php
$method = new ReflectionMethod('IntlChar', 'foldCase');
$options = $method->getParameters()[1];
// All good
var_dump(
"Param name: " . $options->name,
"Is optional: " . $options->isOptional(),
"Type: " . $options->getType(),
"Is default available: " . $options->isDefaultValueAvailable(),
"Is default value constant: ". $options->isDefaultValueConstant(),
"Default const name: " . $options->getDefaultValueConstantName(),
"Default value: " . $options->getDefaultValue(),
);
// But fatal error
var_dump(IntlChar::foldCase('I'));
Activity
damianwadley commentedon Jul 23, 2024
Simple case of the implementation not matching the stubs.
https://github.com/php/php-src/blob/php-8.3.9/ext/intl/uchar/uchar.c#L396-L399
https://github.com/php/php-src/blob/php-8.3.9/ext/intl/uchar/uchar.stub.php#L3419-L3420
IMO should fix the implementation instead.
cmb69 commentedon Jul 23, 2024
This doesn't look like a doc-en issue, though.
cmb69 commentedon Jul 24, 2024
The regression had been introduced with 1f05966 (as such as of PHP 8.0.0). Of course, we cannot fix that for unmaintained and security branches, but likely for
PHP-8.2and up.[-]The optional `options` parameter of the `IntlChar::foldCase` is actually not optional[/-][+]IntlChar::foldCase()'s $option is not optional[/+]Fix phpGH-15087 IntlChar::foldCase()'s $option is not optional
Fix GH-15087 IntlChar::foldCase()'s $option is not optional
Merge branch 'PHP-8.2' into PHP-8.3
Merge branch 'PHP-8.3'