Repository navigation
Php 8.4 - ReflectionProperty->getHooks() on dynamic property results in segmentation fault #15718
Description
Description
The following code:
https://3v4l.org/nurSR/rfc#vgitmaster
<?php
#[\AllowDynamicProperties]
class SegFault
{
}
$segFault = new SegFault();
$segFault->dynamicProp = 'dont call getHooks!';
$reflectionProperty = new ReflectionProperty($segFault, 'dynamicProp');
$reflectionProperty->getHooks();Resulted in this output:
Segmentation fault: 11
But I expected this output instead:
¯\_(ツ)_/¯
getHooks should return an empty array
perhaps throw an exception on a dynamic property
definitely not segFault
PHP Version
PHP 8.4 2024-09-03
Operating System
osx & 3v4l.org
Activity
ndossche commentedon Sep 3, 2024
Intuitively, I suspect that ref->prop is NULL, which also means that getHook has the same problem.
But I'm on mobile rn and can't check.
DanielEScherzer commentedon Sep 3, 2024
Its not just with
#[\AllowDynamicProperties], but also when usingstdClass, or even classes that don't allow dynamic and thus issue a warning while still being used.Its also not just
getHooks(), but alsogetHook(), with this issueDanielEScherzer commentedon Sep 3, 2024
PR at #15721, I don't seem to have the rights to link it as closing this issue
Fix phpGH-15718: ReflectionProperty::get{Hook,Hooks}(): handle dynami…
iluuu1994 commentedon Sep 3, 2024
Thanks @bkdotcom and @DanielEScherzer!
ReflectionProperty::get{Hook,Hooks}(): handle dynamic properties
bkdotcom commentedon Sep 4, 2024
Early adoption for the win!