Using reflection to call Dom\Node::__construct causes assertion failure

Description

The following code:

<?php
$dom = Dom\HTMLDocument::createFromString(<<<HTML
<svg width="1" xmlns:xlink='http://www.w3.org/1999/xlink'>
HTML);
foreach (['svg', 'use', 'mo'] as $tag) {
$el = $dom->getElementsByTagName($tag)[0];
foreach ($el->attributes as $attribute) {
}
}
$rm = new ReflectionMethod($attribute, "__construct");
try {
var_dump($rm->invoke($attribute, 0, 1, 2));
} catch (ReflectionException $exception) {
}

Resulted in this output:

/php-src/ext/dom/node.c:2554: void zim_Dom_Node___construct(zend_execute_data *, zval *): Assertion `0' failed.
Aborted (core dumped)

PHP Version

PHP 8.4.0-dev

Operating System

ubuntu 22.04

Minimal reproduction:

<?php
$dom = Dom\HTMLDocument::createFromString("<svg width=\"1\">");
$el = $dom->getElementsByTagName('svg')[0];
$attribute = $el->attributes->item(0);
$rm = new ReflectionMethod($attribute, "__construct");
$rm->invoke($attribute);

produces:

root@3acd01cef279:/usr/src/php# php /var/www/html/test.php 

Warning: Dom\HTMLDocument::createFromString(): tree error unexpected-token-in-initial-mode in Entity, line: 1, column: 2-4 in /var/www/html/test.php on line 2
php: /usr/src/php/ext/dom/node.c:2551: zim_Dom_Node___construct: Assertion `0' failed.
Aborted

How great, so you can call private methods with this... what's the point of visibility if we have reflection to screw us over...

Fix phpGH-16190: Using reflection to call Dom\Node::__construct cause…

Merge branch 'PHP-8.4'

Fix GH-16190: Using reflection to call Dom\Node::__construct causes a…

Navigation Menu

Repository navigation

Using reflection to call Dom\Node::__construct causes assertion failure #16190

Description

PHP Version

Operating System

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Using reflection to call Dom\Node::__construct causes assertion failure #16190

Description

Description

PHP Version

Operating System

Activity

DanielEScherzer commented on Oct 3, 2024

ndossche commented on Oct 3, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions