Repository navigation
Segfault in exif_thumbnail when not dealing with a real file #16409
Description
Description
The following code:
<?php
$stream = popen('echo 1; echo 2; rm ' . escapeshellarg($tempnam), 'r');
$fusion = proc_open(
'sed "s/^/proc open stdin:/"',
[
0 => $stream,
],
$pipes,
);
exif_thumbnail($stream, $pipes, $stream, $pipes);PHP Version
nightly
Operating System
ubuntu 22.04
Activity
ndossche commentedon Oct 13, 2024
Doesn't reproduce for me, any specific configuration needed?
cmb69 commentedon Oct 13, 2024
This might only happen for ZTS builds. However, on NTS builds
php-src/ext/exif/exif.c
Line 4398 in 79c71c9
might call
stat()with a NULL path.ndossche commentedon Oct 13, 2024
Indeed reproduces on ZTS
[-]Segmentation fault in Zend/zend_virtual_cwd.c:1009[/-][+]Segfault in exif_thumbnail when not dealing with a real file[/+]Fix phpGH-16409: Segfault in exif_thumbnail when not dealing with a r…
Fix GH-16409: Segfault in exif_thumbnail when not dealing with a real…
Merge branch 'PHP-8.2' into PHP-8.3
Merge branch 'PHP-8.3' into PHP-8.4
Merge branch 'PHP-8.4'