Repository navigation
Error dialog causes process to hang #16849
Description
Description
Lines 2121 to 2122 in dd4fc9a
This doesn't appear to produce the desired effect in latest versions of PHP. Dialog asserts are still generated during tests.
From my brief research it doesn't appear that 0 is a valid input for this function.
The better approach would probably be to redirect the output to stderr, as is done here when PHP_WIN32_HEAP_DEBUG is set:
Lines 1181 to 1186 in dd4fc9a
However, setting PHP_WIN32_HEAP_DEBUG enables a bunch of other stuff that isn't necessarily wanted.
This bug is problematic because it causes tests on Windows CIs to get stuck when asserts are triggered in debug builds.
PHP Version
8.1, 8.2, 8.3
Operating System
Windows
Reacted by Christoph M. Becker
Activity
cmb69 commentedon Nov 18, 2024
Indeed, it is undocumented. If I pass e.g.
16instead, I get:Now one might think this is an errenous assertion, but there seems to be special support; from what I can tell it works
_CRTDBG_MODE_FILEand_CRTDBG_FILE_STDERRhave been set. If I only set_CRTDBG_MODE_FILE, the output goes nowhere since the report file defaults toINVALID_HANDLE_VALUE.Not really. The dialogs are about the inevitable error after an assertion failure where
abort()will be called.I think it's probably best to choose a minimal solution as bug fix (i.e. add
_CrtSetReportMode(_CRT_ERROR, 0);), and possibly be more fancy as new feature (the dialogs are nifty during testing if a post-mortem debugger is attached).cmb69 commentedon Nov 18, 2024
Well, it's likely the best memory leak detector available for MSVC builds (might find a couple of other memory related issues, but ASan is far superior). Set
USE_ZEND_ALLOC=0,USE_TRACKED_ALLOC=1andPHP_WIN32_DEBUG_HEAP=1to find leaks when running php.exe (not implemented for other SAPIs).[-]Windows VC++ Runtime assert dialogs are not actually disabled[/-][+]Error dialog causes process to hang[/+]Fix phpGH-16849: Error dialog causes process to hang
dktapps commentedon Nov 18, 2024
Ah, I hadn't realized there was a difference.
Fix GH-16849: Error dialog causes process to hang
Merge branch 'PHP-8.2' into PHP-8.3
Merge branch 'PHP-8.3' into PHP-8.4
Merge branch 'PHP-8.4'
dktapps commentedon Jan 15, 2025
Just an FYI @cmb69 this fix seems to prevent catching assertion failures under Visual Studio Debugger. Might be worth gating these report mode changes behind
!IsDebuggerPresent().cmb69 commentedon Jan 16, 2025
Thanks for the update, @dktapps! I don't think this is caused by e75061b, but there is certainly room for improvement. I'll try to have a closer look, but wouldn't be sad if someone beats me to it – PRs welcome!