Repository navigation
http_build_query type error is inaccurate #18400
Description
Description
The following code:
<?php
enum X{case A;}
echo http_build_query(X::A);Resulted in this output:
Uncaught TypeError: http_build_query(): Argument #1 ($data) must be of type array, X given
But I expected this output instead:
Uncaught TypeError: http_build_query(): Argument #1 ($data) must be of type array|object, X given
Although array|object is also a bit inaccurate, so the exact wording needs to be thought through
PHP Version
8.4+
Operating System
No response
Activity
Girgias commentedon Apr 23, 2025
I wonder if we should start deprecating the use of object properties as hashtables, as it is reasonably easy to get them with
get_object_vars(). And it causes so many issues as objects can be so much more than just a hashmap of properties.ndossche commentedon Apr 23, 2025
I don't know, does it cause that many issues? Here it's just the wording of the message that should be improved 🙂
Girgias commentedon Apr 23, 2025
Well, this issue still exists #10229
As it is nor really possible to determine how such an object should behave
ndossche commentedon Apr 23, 2025
Memory unlocked... Sure, future material though independent from this issue 🙂
Fix phpGH-18400: http_build_query type error is inaccurate
Merge branch 'PHP-8.4'
Fix GH-18400: http_build_query type error is inaccurate