Repository navigation
Signed integer overflow in ext/phar fseek #18642
Description
Description
The following code:
<?php
require_once 'files/phar_oo_test.inc';
class MyFile extends SplFileObject
{
}
$phar = new Phar($fname);
$phar->setInfoClass('MyFile');
$f = $phar['a.php'];
var_dump($f->fseek(PHP_INT_MAX));Resulted in this output:
/home/phpfuzz/WorkSpace/flowfusion/php-src/ext/phar/stream.c:419:22: runtime error: signed integer overflow: 278 + 9223372036854775807 cannot be represented in type 'long'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/phpfuzz/WorkSpace/flowfusion/php-src/ext/phar/stream.c:419:22 in
To reproduce:
./php-src/sapi/cli/php -d "phar.require_hash=0" ./test.php
Commit:
dfff6ac852a23c6e33c06c7716d095ad4a7166d8
Configurations:
CC="clang-12" CXX="clang++-12" CFLAGS="-DZEND_VERIFY_TYPE_INFERENCE" CXXFLAGS="-DZEND_VERIFY_TYPE_INFERENCE" ./configure --enable-debug --enable-address-sanitizer --enable-undefined-sanitizer --enable-re2c-cgoto --enable-fpm --enable-litespeed --enable-phpdbg-debug --enable-zts --enable-bcmath --enable-calendar --enable-dba --enable-dl-test --enable-exif --enable-ftp --enable-gd --enable-gd-jis-conv --enable-mbstring --enable-pcntl --enable-shmop --enable-soap --enable-sockets --enable-sysvmsg --enable-zend-test --with-zlib --with-bz2 --with-curl --with-enchant --with-gettext --with-gmp --with-mhash --with-ldap --with-libedit --with-readline --with-snmp --with-sodium --with-xsl --with-zip --with-mysqli --with-pdo-mysql --with-pdo-pgsql --with-pgsql --with-sqlite3 --with-pdo-sqlite --with-webp --with-jpeg --with-freetype --enable-sigchild --with-readline --with-pcre-jit --with-iconv
Operating System:
Ubuntu 20.04 Host, Docker 0599jiangyc/flowfusion:latest
This report is automatically generated by FlowFusion
PHP Version
dfff6ac852a23c6e33c06c7716d095ad4a7166d8
Operating System
No response
Reacted by David CARLIER and Lizardo
Activity
devnexen commentedon May 24, 2025
The way it seems to be => risk of overflow => newoffset at -1 then return -1 immediatly.
devnexen commentedon May 24, 2025
ah well nielsdos into it already :D
[-]signed integer overflow in fseek[/-][+]Signed integer overflow in ext/phar fseek[/+]Fix phpGH-18642: Signed integer overflow in ext/phar fseek
Fix GH-18642: Signed integer overflow in ext/phar fseek
Merge branch 'PHP-8.3' into PHP-8.4
Merge branch 'PHP-8.4'