setlocale($type, NULL) should not be deprecated #19070

Activity

1. remicollet

   added

   Bug

   Status: Needs Triage

   on Jul 8, 2025
2. remicollet commented on Jul 8, 2025

   

   remicollet

   on Jul 8, 2025

   MemberAuthor

   More actions

   ping @nielsdos as the author of the change
3. remicollet

   changed the title [-]setlocale($type, NULL) shoud not be deprecated[/-] [+]setlocale($type, NULL) should not be deprecated[/+] on Jul 8, 2025
4. remicollet commented on Jul 8, 2025

   

   remicollet

   on Jul 8, 2025

   MemberAuthor

   More actions

   Notice: our documentation is confusing

   If locales is "0", the locale setting is not affected, only the current setting is returned.

   $ php -r 'var_dump(setlocale(LC_ALL, null));'
   string(11) "fr_FR.UTF-8"
   
   $ php -r 'var_dump(setlocale(LC_ALL, 0));'
   string(166) "LC_CTYPE=C.UTF-8;LC_NUMERIC=C;LC_TIME=C;LC_COLLATE=C;LC_MONETARY=C;LC_MESSAGES=C;LC_PAPER=C;LC_NAME=C;LC_ADDRESS=C;LC_TELEPHONE=C;LC_MEASUREMENT=C;LC_IDENTIFICATION=C"
   
   $ php -r 'var_dump(setlocale(LC_ALL, "0"));'
   string(166) "LC_CTYPE=C.UTF-8;LC_NUMERIC=C;LC_TIME=C;LC_COLLATE=C;LC_MONETARY=C;LC_MESSAGES=C;LC_PAPER=C;LC_NAME=C;LC_ADDRESS=C;LC_TELEPHONE=C;LC_MEASUREMENT=C;LC_IDENTIFICATION=C"
   

   Only null returns the current setting.
5. remicollet commented on Jul 8, 2025

   

   remicollet

   on Jul 8, 2025

   MemberAuthor

   More actions

   Also see documentation update proposal in https://github.com/php/doc-en/pull/4765/files
6. ndossche

   added

   Extension: standard

   Status: Verified

   and removed

   Status: Needs Triage

   on Jul 8, 2025
7. ndossche

   self-assigned this

   on Jul 8, 2025
8. ndossche commented on Jul 8, 2025

   

   ndossche

   on Jul 8, 2025

   Member

   More actions

   Unintentional break! I'll go fix it. It should indeed accept NULL.
9. ndossche

   added a commit that references this issue on Jul 8, 2025

   Fix phpGH-19070: setlocale($type, NULL) should not be deprecated

   ...

   This issue will close once commit e004c22 is merged into the 'master' branch.

   e004c22
10. ndossche

    linked a pull request that will close this issueFix GH-19070: setlocale($type, NULL) should not be deprecated #19071on Jul 8, 2025
11. ndossche

    closed this as completedin c4183fbon Jul 10, 2025
12. pull

    added a commit that references this issue on Jul 10, 2025

    Fix phpGH-19070: setlocale($type, NULL) should not be deprecated

    ...

    This issue will close once commit c4183fb is merged into the 'master' branch.

    c4183fb