Skip to content

Windows: _get_osfhandle asserts in debug mode when given a socket #19722

Closed
Closed
Windows: _get_osfhandle asserts in debug mode when given a socket#19722
Labels
BugOS: WindowsStatus: Verified

Description

@dktapps
dktapps
opened on Sep 5, 2025

php-src/win32/select.c

Line 69 in 66eb5e7

handles[n_handles] = (HANDLE)(uintptr_t)_get_osfhandle(i);

When calling stream_select() with a stream socket, this will assert in debug binaries, which makes it inconvenient to test some applications.

I'm not sure what could be done to address this. There doesn't seem to be an easy way to ask the CRT if the fd is a file resource.

According to ChatGPT getsockopt() and checking for WSAENOTSOCK might be a better way to check for sockets, but I haven't tried this myself.
Hoping someone with more expertise about the depths of Windows can suggest something.

Activity

  1. devnexen commented on Sep 5, 2025

    @devnexen
    devnexen
    on Sep 5, 2025
    Member

    Hi @dktapps sorry to hijack your ticket, seems you seem to know well windows, if I m not asking too much, would you mind having a look there ? Cheers.

  2. dktapps
    added a commit that references this issue on Sep 5, 2025

    Proposed fix for php#19722

    fabe490
  3. ndossche
    added
    Bug
    OS: Windows
    Status: Verified
    on Sep 7, 2025
  4. ndossche
    linked a pull request that will close this issueAlternative check for sockets in win32/select.c, fixes #19722 #19725on Sep 10, 2025
  5. ndossche
    closed this as completedin 36057b9on Sep 10, 2025
  6. pull
    added a commit that references this issue on Sep 10, 2025

    Fix phpGH-19722: Windows: _get_osfhandle asserts in debug mode when g…

    36057b9
  7. ndossche
    added 4 commits that reference this issue on Oct 15, 2025

    Fix GH-19722: Windows: _get_osfhandle asserts in debug mode when give…

    94625a0

    Merge branch 'PHP-8.3' into PHP-8.4

    8dd117f

    Merge branch 'PHP-8.4' into PHP-8.5

    0ef96a2

    Merge branch 'PHP-8.5'

    8dc1a3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugOS: WindowsStatus: Verified

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions