Repository navigation
XP_SOCKET XP_SSL (Socket stream modules): Incorrect condition for Win32/Win64 #19798
Description
php-src/main/streams/xp_socket.c
Line 880 in 49fdf49
if (clisock >= 0) {This condition will never be true on Windows, because the type php_socket_t is UINT_PTR, and the value -1 will always be greater than zero.
Correct fix: introduce the INVALID_SOCKET constant for both platforms.
Activity
[-]Incorrect condition for Win32/Win64[/-][+]XP_SOCKET XP_SSL (Socket stream modules): Incorrect condition for Win32/Win64[/+]EdmondDantes commentedon Sep 11, 2025
bukka commentedon Sep 19, 2025
Good that you noticed this master regression that was introduced in #19106 . It's actually not an issue on lower branches and xp_ssl where int was used but that master refactoring changed type. The behavior wasn't really correct on lower branches anyway as it was relying on implementation defined behavior (changing signedness when casting unsigned to signed) so I created a fix for that in #19881.
Btw. there is already
SOCK_ERRfor what you described...bukka commentedon Sep 19, 2025
Sorry linked the wrong issue before (edited now): Fix is in #19881
Fix GH-19798: XP_SOCKET XP_SSL: Incorrect condition for Win
Merge branch 'PHP-8.3' into PHP-8.4
Merge branch 'PHP-8.4' into PHP-8.5
Merge branch 'PHP-8.5'