Repository navigation
Spoofchecker::setRestrictionLevel() error message suggests missing constants #20426
Description
Description
The following code:
<?php
try {
(new Spoofchecker())->setRestrictionLevel( -2 );
} catch ( \Throwable $e ) {
// Show the error message
echo $e->getMessage() . "\n\n";
}
$cases = [
'Spoofchecker::ASCII',
'Spoofchecker::SINGLE_SCRIPT_RESTRICTIVE',
'Spoofchecker::SINGLE_HIGHLY_RESTRICTIVE',
'Spoofchecker::SINGLE_MODERATELY_RESTRICTIVE',
'Spoofchecker::SINGLE_MINIMALLY_RESTRICTIVE',
'Spoofchecker::UNRESTRICTIVE',
];
foreach ( $cases as $case ) {
if ( defined( $case ) ) {
echo "$case - is defined\n";
} else {
echo "$case - NOT defined\n";
}
}Resulted in this output:
Spoofchecker::setRestrictionLevel(): Argument #1 ($level) must be one of Spoofchecker::ASCII, Spoofchecker::SINGLE_SCRIPT_RESTRICTIVE, Spoofchecker::SINGLE_HIGHLY_RESTRICTIVE, Spoofchecker::SINGLE_MODERATELY_RESTRICTIVE, Spoofchecker::SINGLE_MINIMALLY_RESTRICTIVE, or Spoofchecker::UNRESTRICTIVE
Spoofchecker::ASCII - is defined
Spoofchecker::SINGLE_SCRIPT_RESTRICTIVE - is defined
Spoofchecker::SINGLE_HIGHLY_RESTRICTIVE - NOT defined
Spoofchecker::SINGLE_MODERATELY_RESTRICTIVE - NOT defined
Spoofchecker::SINGLE_MINIMALLY_RESTRICTIVE - NOT defined
Spoofchecker::UNRESTRICTIVE - is defined
But I expected this output instead:
- ValueError message only suggests class constants that exist
PHP Version
8.3+
Operating System
No response
Activity
DanielEScherzer commentedon Nov 8, 2025
Presumably the fix is
Tested with https://3v4l.org/Gg9r9
The question is just what version of PHP should the fix be sent to - 8.3 or master? I'm happy to do the actual work
devnexen commentedon Nov 8, 2025
yes you would need to update the exception message in 8.3
Fix phpGH-20426: fix Spoofchecker::setRestrictionLevel() error
Fix GH-20426: fix Spoofchecker::setRestrictionLevel() error (#20427)
Merge branch 'PHP-8.3' into PHP-8.4
Merge branch 'PHP-8.4' into PHP-8.5
Merge branch 'PHP-8.5'