Skip to content

Typo in pgsql_driver.c: duplicated constant in a switch #21055

Closed
Closed
Typo in pgsql_driver.c: duplicated constant in a switch#21055

Description

@lsaos
lsaos
opened on Jan 28, 2026

There is a mistake in pgsql_driver.c, probably a typo:

php-src/ext/pdo_pgsql/pgsql_driver.c

Line 523 in cc50c9e

case CONNECTION_SSL_STARTUP:

It should be case CONNECTION_GSS_STARTUP and not case CONNECTION_SSL_STARTUP according to the #ifdef, message description and the CONNECTION_SSL_STARTUP is 10 lines above. I believe it never got caught because this module was never compiled with CONNECTION_GSS_STARTUP present.

Activity

  1. devnexen
    closed this as completedin 3037526on Jan 28, 2026
  2. devnexen
    added 3 commits that reference this issue on Jan 28, 2026

    Merge branch 'PHP-8.4' into PHP-8.5

    00466a0

    Merge branch 'PHP-8.5'

    b16e534

    Fix GH-21055: Pdo/Pgsql typo for GSS negotiation connection status at…

    3037526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions