Repository navigation

PHP fails to build if openssl was built with --no-ec #9064

Closed

Labels

BugExtension: opensslStatus: Verified

opened

on Jul 20, 2022

Description

Looking at openssl.c:

HAVE_EVP_PKEY_EC is defined only if OPENSSL_NO_EC is defined:
https://github.com/php/php-src/blob/php-8.1.8/ext/openssl/openssl.c#L89
```
#if !defined(OPENSSL_NO_EC) && defined(EVP_PKEY_EC)
#define HAVE_EVP_PKEY_EC 1
#endif
```
OPENSSL_KEYTYPE_EC is defined only if HAVE_EVP_PKEY_EC is defined:
https://github.com/php/php-src/blob/php-8.1.8/ext/openssl/openssl.c#L107
```
#ifdef HAVE_EVP_PKEY_EC
	OPENSSL_KEYTYPE_EC = OPENSSL_KEYTYPE_DH +1
#endif
```
but then on line 4899 it is used without proper #ifdef's:
https://github.com/php/php-src/blob/php-8.1.8/ext/openssl/openssl.c#L4898
```
		case EVP_PKEY_EC: {
			ktype = OPENSSL_KEYTYPE_EC;
```

Worth noting that further down it's properly #ifdef'd out:
https://github.com/php/php-src/blob/php-8.1.8/ext/openssl/openssl.c#L5003

#ifdef HAVE_EVP_PKEY_EC
		case EVP_PKEY_EC:
			ktype = OPENSSL_KEYTYPE_EC;

Probably it should be #ifdef'd on line 4899, too?

PHP Version

8.1.8

Operating System

No response

Lex-2008
added
Bug

Status: Needs Triage
on Jul 20, 2022
Lex-2008
added a commit that references this issue on Jul 20, 2022
php compilation breaks if openssl built with no-ec
ba11f1a
cmb69 commented on Jul 20, 2022
cmb69
on Jul 20, 2022
Member
Indeed, looks like this occurrence has been overlooked.
cmb69
added
Extension: openssl

Status: Verified
and removed
Status: Needs Triage
on Jul 20, 2022
Lex-2008
added a commit that references this issue on Jul 21, 2022
Add many no's to openssl configure
ef0ce61
vpodzime
added 2 commits that reference this issue on Aug 2, 2022
Add many no's to openssl configure
5a3cd18
Add many no's to openssl configure
31f7b12
Lex-2008
added a commit that references this issue on Aug 19, 2022
Add many no's to openssl configure
8b62307
Lex-2008
added 2 commits that reference this issue on Sep 12, 2022
Add many no's to openssl configure
1caaacd
Disable unused openssl features
09a3e88
Lex-2008
added 2 commits that reference this issue on Sep 21, 2022
Disable unused openssl features
b31aa93
Disable unused openssl features
b75b527
bukka
added a commit that references this issue on Nov 25, 2022
Fix GH-9064: PHP fails to build if openssl was built with no-ec
ce57221
bukka
closed this as completedin ce57221 on Nov 25, 2022

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

BugExtension: opensslStatus: Verified

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests