random extension is not thread safe #9067

Activity

1. ophian

   added

   Bug

   Status: Needs Triage

   on Jul 20, 2022
2. devnexen

   assigned

   cmb69

   on Jul 20, 2022
3. cmb69 commented on Jul 20, 2022

   

   cmb69

   on Jul 20, 2022

   Member

   More actions

   I can confirm segfaults with non-trivial scripts with apache2handler. I need to investigate closer.
4. cmb69

   added

   OS: Windows

   Status: Verified

   and removed

   Status: Needs Triage

   on Jul 20, 2022
5. cmb69 commented on Jul 20, 2022

   

   cmb69

   on Jul 20, 2022

   Member

   More actions

   Simple reproducer:

   <?php
   session_start();

   Stack backtrace:

   >	php8ts.dll!php_combined_lcg() Zeile 426	C
    	php8ts.dll!php_session_gc(bool immediate) Zeile 373	C
    	php8ts.dll!php_session_initialize() Zeile 453	C
    	php8ts.dll!php_session_start() Zeile 1617	C
    	php8ts.dll!zif_session_start(_zend_execute_data * execute_data, _zval_struct * return_value) Zeile 2542	C
    	php8ts.dll!ZEND_DO_ICALL_SPEC_RETVAL_UNUSED_HANDLER(_zend_execute_data * execute_data) Zeile 1265	C
    	php8ts.dll!execute_ex(_zend_execute_data * ex) Zeile 55689	C
    	php8ts.dll!zend_execute(_zend_op_array * op_array, _zval_struct * return_value) Zeile 60255	C
    	php8ts.dll!zend_execute_scripts(int type, _zval_struct * retval, int file_count, ...) Zeile 1771	C
    	php8ts.dll!php_execute_script(_zend_file_handle * primary_file) Zeile 2535	C
    	php8apache2_4.dll!php_handler(request_rec * r) Zeile 708	C
    	[Externer Code]	
   

   php-src/ext/random/random.c

   Line 423 in c2f5bd1

   php_random_status *status = RANDOM_G(combined_lcg);

   status == NULL after initialization.
6. cmb69 commented on Jul 20, 2022

   

   cmb69

   on Jul 20, 2022

   Member

   More actions

   The problem is that the new random extension doesn't implement a GINIT function and as such is not properly thread safe. I think that the following code needs to be moved (and adapted) to GINIT:

   php-src/ext/random/random.c

   Lines 843 to 849 in c2f5bd1

   	RANDOM_G(random_fd) = -1;
   	RANDOM_G(combined_lcg) = php_random_status_alloc(&php_random_algo_combinedlcg, true);
   	RANDOM_G(combined_lcg_seeded) = false;
   	RANDOM_G(mt19937) = php_random_status_alloc(&php_random_algo_mt19937, true);
   	RANDOM_G(mt19937_seeded) = false;
7. cmb69

   changed the title [-]PHP 8.2-beta1 Win build has networking issue[/-] [+]random extension is not thread safe[/+] on Jul 20, 2022
8. cmb69

   added

   Extension: random

   and removed

   OS: Windows

   on Jul 20, 2022
9. ophian commented on Jul 20, 2022

   

   ophian

   on Jul 20, 2022

   Last edited by ophian

   Author

   More actions

   I hear you Christoph... Hoping all the best. 😎
   Thank you for taking all that extra time and effort to get this sorted out!
10. cmb69 commented on Jul 20, 2022

    

    cmb69

    on Jul 20, 2022

    Member

    More actions

    Thanks for reporting! I'm consulting with the release managers on what to do about this issue.
11. cmb69

    added a commit that references this issue on Jul 20, 2022

    Fix phpGH-9067: random extension is not thread safe

    ...

    This issue will close once commit bc6eaf0 is merged into the 'master' branch.

    bc6eaf0
12. cmb69

    linked a pull request that will close this issueFix GH-9067: random extension is not thread safe #9070on Jul 20, 2022
13. cmb69

    closed this as completedin 8487d8fon Jul 21, 2022