Segmentation fault in mb_strimwidth() #9248

Activity

1. garas

   added

   Bug

   Status: Needs Triage

   on Aug 4, 2022
2. Girgias

   assigned

   alexdowad

   on Aug 4, 2022
3. Girgias

   added

   Extension: mbstring

   Status: Verified

   and removed

   Status: Needs Triage

   on Aug 4, 2022
4. cmb69 commented on Aug 5, 2022

   

   cmb69

   on Aug 5, 2022

   Member

   More actions

   Indeed, we need to initialize trimmarker:

    ext/mbstring/mbstring.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)
   
   diff --git a/ext/mbstring/mbstring.c b/ext/mbstring/mbstring.c
   index b9cfe628b4..24712c8817 100644
   --- a/ext/mbstring/mbstring.c
   +++ b/ext/mbstring/mbstring.c
   @@ -2502,7 +2502,7 @@ static zend_string* mb_trim_string(zend_string *input, zend_string *marker, cons
    /* Trim the string to terminal width; optional, add a 'trim marker' if it was truncated */
    PHP_FUNCTION(mb_strimwidth)
    {
   -	zend_string *str, *trimmarker, *encoding = NULL;
   +	zend_string *str, *trimmarker = zend_empty_string, *encoding = NULL;
    	zend_long from, width;
    
    	ZEND_PARSE_PARAMETERS_START(3, 5)
5. alexdowad commented on Aug 5, 2022

   

   alexdowad

   on Aug 5, 2022

   Contributor

   More actions

   Thanks for the great catch! Much appreciated!
6. alexdowad commented on Aug 5, 2022

   

   alexdowad

   on Aug 5, 2022

   Contributor

   More actions

   @cmb69, do you want to commit this fix, or should I include it in my next PR?
7. cmb69

   added a commit that references this issue on Aug 8, 2022

   Fix phpGH-9248: Segmentation fault in mb_strimwidth()

   ...

   This issue will close once commit 98598f2 is merged into the 'master' branch.

   98598f2
8. cmb69

   linked a pull request that will close this issueFix GH-9248: Segmentation fault in mb_strimwidth() #9273on Aug 8, 2022
9. cmb69 commented on Aug 8, 2022

   

   cmb69

   on Aug 8, 2022

   Member

   More actions

   I just submitted PR #9273. :)
10. cmb69

    closed this as completedin d013d94on Aug 8, 2022
11. alexdowad commented on Aug 8, 2022

    

    alexdowad

    on Aug 8, 2022

    Contributor

    More actions

    Thanks very much!