Repository navigation
zend_hash_check_size: allow nSize <= HT_MAX_SIZE - #10244
Merged
Merged
Conversation
This is consistent with other uses of HT_MAX_SIZE
Girgias
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zend_hash_check_size() restricts the nSize parameter to be strictly less than HT_MAX_SIZE, which makes the name of the HT_MAX_SIZE macro slightly confusing.
In this PR I change zend_hash_check_size() so that it allows nSize values <= HT_MAX_SIZE instead of strictly < HT_MAX_SIZE.
This does not actually extend the maximum hash size, as it was already possible to create hashes with a size of HT_MAX_SIZE:
HT_MAX_SIZEfor nSize values in the range]HT_MAX_SIZE/2...HT_MAX_SIZE[I found this while testing #10149. Also related: #10242.