Repository navigation
Conversation
bukka
force-pushed
the
fpm_fcgi_envs_ap_pp_sn_strip_enc
branch
from
March 17, 2023 14:59
b29b0c4 to
f8a4e92
Compare
Girgias
reviewed
Mar 17, 2023
Girgias
left a comment
Member
There was a problem hiding this comment.
Minor type nits.
Can't really comment on the rest, but I'm expecting this works and is tested properly.
… spaces are in path
bukka
force-pushed
the
fpm_fcgi_envs_ap_pp_sn_strip_enc
branch
from
March 18, 2023 20:31
f8a4e92 to
49fa103
Compare
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in the pull request, this is caused by the fact that Apache URL decodes path info in the SCRIPT_NAME because it is required in CGI RFC.