Skip to content

Fix GH-11338: SplFileInfo empty getBasename with more than on slash - #11340

Closed
ndossche wants to merge 1 commit into
php:PHP-8.1from
ndossche:fix-11338
Closed

ndossche wants to merge 1 commit into
php:PHP-8.1from
ndossche:fix-11338

Conversation

@ndossche

Copy link
Copy Markdown
Member

Regressed in 13e4ce3.

@ndossche
ndossche requested review from Girgias and dstogov May 29, 2023 14:19

@Girgias Girgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the regression: https://3v4l.org/JFmUj and see that this fixes it.

Are the normal basename() and filename() functions working as intended?

Comment thread ext/spl/tests/gh11338.phpt Resolved
@ndossche

ndossche commented May 29, 2023 •

Copy link
Copy Markdown
Member Author

Are the normal basename() and filename() functions working as intended?

Yes, although AFAICT there is no filename() global function, basename() does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SplFileInfo empty getBasename with more than on slash after PHP 8.1.1

2 participants