Repository navigation
Conversation
… null type The check would only work for the ?type syntax, but not type|null. Switch to a check during type compilation instead. Fixes phpGH-11488
This was referenced Jun 21, 2023
Closed
Girgias
approved these changes
Jun 21, 2023
Girgias
left a comment
Member
There was a problem hiding this comment.
LGTM
I do think we should look into deprecating the legacy way of declaring a nullable type as it makes for some confusing rules.
Member
|
MacOS failure is unrelated. But again LGTM still :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check would only work for the ?type syntax, but not type|null. Switch to a check during type compilation instead.
Fixes GH-11488