Skip to content

fix #11522 - #11524

Closed
SVGAnimate wants to merge 1 commit into
php:masterfrom
SVGAnimate:m4_php_version_cut_suffix
Closed

SVGAnimate wants to merge 1 commit into
php:masterfrom
SVGAnimate:m4_php_version_cut_suffix

Conversation

@SVGAnimate

Copy link
Copy Markdown
Contributor

Remove php version suffix from '-' separator

Remove php version suffix from '-' separator
@SVGAnimate

Copy link
Copy Markdown
Contributor Author

Warning: socket_sendto(): Unable to write to socket [105]: No buffer space available in /tmp/cirrus-ci-build/ext/sockets/tests/socket_sendto_zerocopy.php on line 25

@SVGAnimate SVGAnimate closed this Jun 24, 2023
@ndossche

Copy link
Copy Markdown
Member

Warning: socket_sendto(): Unable to write to socket [105]: No buffer space available in /tmp/cirrus-ci-build/ext/sockets/tests/socket_sendto_zerocopy.php on line 25

The error you saw is spurious. These can fail when the CI is under high I/O pressure.

@ndossche

Copy link
Copy Markdown
Member

I think this looks good. I'm not sure why you closed this, but feel free to reopen if you feel comfortable submitting this. :)

@iluuu1994 iluuu1994 reopened this Jun 26, 2023
@iluuu1994

iluuu1994 commented Jun 26, 2023 •

Copy link
Copy Markdown
Member

AFAIK it's somewhat discouraged to use dev PHP versions for stub_gen/vm_gen etc, but if that's a rule we should make it explicit in the build script. This looks good to me for now.

@ndossche ndossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iluuu1994 This also reproduces on some distros where the distro suffixes the PHP version, e.g. 7.2.24-0ubuntu0.16.04.16 as in the original report. (It's outdated of course, but it shows the point)
This scenario would break stub generation, so I think we should also backport it to 8.1 & 8.2. WDYT?

@iluuu1994

Copy link
Copy Markdown
Member

Ah, I missed that part. Sure, backporting should be fine.

@ndossche ndossche self-assigned this Jun 27, 2023
@ndossche ndossche linked an issue Jun 27, 2023 that may be closed by this pull request
@ndossche ndossche closed this in 3483229 Jun 27, 2023
@ndossche

Copy link
Copy Markdown
Member

Thank you @SVGAnimate !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

checking for php... php

3 participants