Repository navigation
Conversation
dstogov
approved these changes
Mar 5, 2024
Member
Author
|
Merged 6b57e2d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #13569.
This is caused by a wrong condition in
gc_extra_root()causing it to grow the root buffer when it's not necessary: It grows the buffer when thefirst_unusedslot is higher or equal togc_threshold. Additionally, this condition applies repeatedly because the threshold is (legitimately) not updated in this case, thus the buffer size quickly grows towardsGC_MAX_BUF_SIZE, after which anE_WARNINGis triggered and the GC is disabled.The fix is to compare
first_unusedtobuf_sizeinstead.