Skip to content

Fix GH-14183: XMLReader::open() can't be overridden - #14194

Closed
ndossche wants to merge 1 commit into
php:PHP-8.2from
ndossche:xmlreader-fix-overrides
Closed

ndossche wants to merge 1 commit into
php:PHP-8.2from
ndossche:xmlreader-fix-overrides

Conversation

@ndossche

Copy link
Copy Markdown
Member

We should only return the override if the internal static method is matched.

We should only return the override if the internal static method is matched.
@ndossche ndossche linked an issue May 10, 2024 that may be closed by this pull request

@devnexen devnexen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndossche ndossche closed this in 15813d6 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XMLReader::open() can't be overridden

2 participants