Repository navigation
[skip ci] Add NEWS for GH-15824 - #15835
Merged
Merged
Conversation
youkidearitai
referenced
this pull request
Sep 11, 2024
I fixed from strcasecmp to strncasecmp. However, strncasecmp is specify size to #3 parameter. Hence, Add check length to mime and aliases. Co-authored-by: Niels Dossche <[email protected]>
ndossche
reviewed
Sep 11, 2024
Co-authored-by: Niels Dossche <[email protected]>
Member
|
This is fix is not in PHP 8.4.0beta5 (that already had been tagged earlier), so should be moved to the respective section (8.4.0RC1). Also, the subsections (MBString, etc.) should be in alphabetic order. |
Contributor
Author
|
@cmb69 I see. Thank you. Fixed. |
Member
|
Oh, forgot: thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot to add a
NEWSentry.cc @alexdowad