Repository navigation
Conversation
New hash tables are not automatically packed, so we must not treat them as such. Therefore we guard the foreach appropriately.
iluuu1994
left a comment
There was a problem hiding this comment.
HT_IS_INITIALIZED() would make slightly more sense to me, but this looks fine too.
Ah, right, when reading the code this is better. However, for maintenance using |
|
Indeed, but then at least we'd crash, rather than just silently not hand the array. |
|
Makes sense. Changed to |
|
The macOS CI failure seems to be unrelated to the PR. |
ndossche
left a comment
There was a problem hiding this comment.
LGTM
and yeah, curl has started failing on macOS since yesterday or so, it's unrelated
Should we update the PHP-8.2 macOS CI? |
|
@cmb69 Do you know what the cause is? I have no clue. The failures are seemingly random, although it's always the same tests that fail. |
|
@iluuu1994, hmm, just guessing, but might be due to https://github.com/php/php-src/pull/15877/files#diff-ef4c5569bff099e37e482441804e39e99ca75e1a0cdb13bf555a99a2f4feef3cL21. |
|
I see around 20 successfully macOS builds after that commit, so it seems unlikely. But who knows? |
|
See #15958. If that fails, it's something else; if it succeeds, well, who knows? :) |
|
Well, #15958 failed; we may continue the discussion there. |
New hash tables are not automatically packed, so we must not treat them as such. Therefore we guard the foreach appropriately.