Repository navigation
Conversation
cmb69
reviewed
Oct 1, 2024
TimWolla
reviewed
Oct 2, 2024
TimWolla
reviewed
Oct 2, 2024
ndossche
reviewed
Oct 2, 2024
ndossche
reviewed
Oct 2, 2024
ndossche
reviewed
Oct 2, 2024
Member
There was a problem hiding this comment.
Can use ZVAL_NEW_STR here, but not terribly important.
ndossche
reviewed
Oct 3, 2024
ndossche
approved these changes
Oct 3, 2024
ndossche
left a comment
Member
There was a problem hiding this comment.
This is right as far as I understand. But maybe wait for like at least one more approval.
cmb69
reviewed
Oct 3, 2024
cmb69
left a comment
Member
There was a problem hiding this comment.
Besides the nits, this looks good to me.
Member
There was a problem hiding this comment.
If you revert the conditions, you can simplify:
Suggested change
| if ((entry == NULL && with_comma) || !with_comma) { | |
| if (!with_comma || entry == NULL) { |
This is the same as with_comma → entry == NULL (logical implication).
Member
There was a problem hiding this comment.
Superfluous empty line:
Suggested change
Those are meant to have 1 or plus values separated by a comma even if the client set them separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those are meant to have 1 or plus values separated by a comma even
if the client set them separately.