Skip to content

Fix GH-16523: FILTER_FLAG_HOSTNAME accepts ending hyphen - #16540

Closed
cmb69 wants to merge 1 commit into
php:PHP-8.2from
cmb69:cmb/gh16523
Closed

cmb69 wants to merge 1 commit into
php:PHP-8.2from
cmb69:cmb/gh16523

Conversation

@cmb69

@cmb69 cmb69 commented Oct 21, 2024

Copy link
Copy Markdown
Member

Domain name labels must not end with a hyphen, and that is also true for the last label. Apparently, this has been overlooked so far.

Domain name labels must not end with a hyphen, and that is also true
for the last label.  Apparently, this has been overlooked so far.
@cmb69 cmb69 linked an issue Oct 21, 2024 that may be closed by this pull request

@devnexen devnexen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmb69 cmb69 closed this in f9ce5e7 Oct 21, 2024
@cmb69
cmb69 deleted the cmb/gh16523 branch October 21, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FILTER_FLAG_HOSTNAME accepts ending hyphen

2 participants