Repository navigation
Conversation
Member
Author
|
There are also some more issues with |
Member
|
I didnt properly check when I wrote my comment that we could simply delay destructors, but indeed this seems to work too in this case. |
Girgias
reviewed
Oct 31, 2024
Girgias
left a comment
Member
There was a problem hiding this comment.
global and $GLOBALS do be the bane of my existence with all the whack bugs it can create.
But this looks reasonable
Member
Author
|
Along with references, error handlers and destructors. ^^ Unfortunately, they are also kind of useful. 😄 |
Member
|
Very true :') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-16646