Repository navigation
Fix GH-16990 "dba_list() is now zero-indexed instead of using resourc… - #17005
kocsismate wants to merge 3 commits into
Conversation
b795a26 to
3dbcced
Compare
3dbcced to
b3ae8ea
Compare
Girgias
left a comment
There was a problem hiding this comment.
MSTM, @alexandre-daubois can you confirm this fixes the issue?
Yes, basically that's the case (with the caveat that it's the object ID in fact, since the resource to object conversion) |
|
Small caveat: as far as I know, object IDs reusable (contrary to resource IDs). Might not matter in practice, though. |
Yes they are indeed, see: https://3v4l.org/brMEt |
| $handler = "flatfile"; | ||
| require_once(__DIR__ .'/skipif.inc'); |
There was a problem hiding this comment.
Thanks for pointing this out!
ndossche
left a comment
There was a problem hiding this comment.
Ok for me except the test thing that cmb pointed out
| $handler = "flatfile"; | ||
| require_once(__DIR__ .'/skipif.inc'); | ||
| require_once __DIR__ . '/setup/setup_dba_tests.inc'; | ||
| check_skip('inifile'); |
There was a problem hiding this comment.
Euh, flatfile or inifile? I suppose this needs to say flatfile
There was a problem hiding this comment.
I managed to blindly copy-paste the SKIPIF snippet.
…e ids"