Repository navigation
Conversation
Member
|
seems needs an upstream fix ? |
cmb69
marked this pull request as draft
January 6, 2025 10:53
Member
Author
The unintended fallthrough has already been fixed: libgd/libgd@6d21d30 The UB likely has been fixed with libgd/libgd@2b26be8. What a mess! Need to check more thoroughly. |
We port the respective upstream fix[1], which dropped the special cased implementations of fixed-point arithmetic rotation in favor of the generic implementation. [1] <libgd/libgd@bd6d2e1>
cmb69
marked this pull request as ready for review
January 6, 2025 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We port the respective upstream fix[1], which dropped the special cased implementations of fixed-point arithmetic rotation in favor of the generic implementation.
[1] libgd/libgd@bd6d2e1
It's a bit unfortunate that due to the change to the
gdInterpolationMethodenum this likely has to be regarded as ABI break, and as such can only target the master branch. It's even more unfortunate, that I thought that the special case implementations had not been ported to libgd back then, when actually they just had been removed just a few months before.