Skip to content

Fix GH-17486: Incorrect error line numbers reported in Dom\HTMLDocument::createFromString - #17491

Closed
ndossche wants to merge 4 commits into
php:PHP-8.4from
ndossche:fix-17486
Closed

ndossche wants to merge 4 commits into
php:PHP-8.4from
ndossche:fix-17486

Conversation

@ndossche

Copy link
Copy Markdown
Member

No description provided.

@ndossche

Copy link
Copy Markdown
Member Author

I don't immediately see why on some CI jobs it's not emitting the warning and I'm too tired to figure that out now.

@xPaw

xPaw commented Jan 16, 2025

Copy link
Copy Markdown
Contributor


 wont trigger a warning because of the fix in ac266c9

@ndossche

Copy link
Copy Markdown
Member Author

Ah of course, and this was branched off of 8.4 before I cherry-picked that... Thanks!

@devnexen devnexen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM

@ndossche ndossche closed this in 21c170c Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect error line numbers reported in Dom\HTMLDocument::createFromString

3 participants