Skip to content

Fix #[\Deprecated] for __call() and __callStatic() - #17592

Merged
TimWolla merged 2 commits into
php:PHP-8.4from
TimWolla:deprecated-magic-call
Jan 27, 2025
Merged

TimWolla merged 2 commits into
php:PHP-8.4from
TimWolla:deprecated-magic-call

Conversation

@TimWolla

@TimWolla TimWolla commented Jan 27, 2025 •

Copy link
Copy Markdown
Member

Fixes GH-17597.

/cc @beberlei

Comment thread NEWS Resolved
@TimWolla
TimWolla force-pushed the deprecated-magic-call branch from 321bcde to 22dc09c Compare January 27, 2025 11:30
Comment thread Zend/zend_object_handlers.c Resolved
Comment thread Zend/zend_object_handlers.h Resolved
@TimWolla
TimWolla merged commit f37b165 into php:PHP-8.4 Jan 27, 2025
TimWolla added a commit that referenced this pull request Jan 27, 2025
* PHP-8.4:
  Fix `#[\Deprecated]` for `__call()` and `__callStatic()` (#17592)
@TimWolla
TimWolla deleted the deprecated-magic-call branch January 27, 2025 12:42
ndossche added a commit to ndossche/php-src that referenced this pull request Feb 21, 2025
…4.3 to 8.4.4

This regressed in phpGH-17592.
The function is with its attributes HashTable* is copied in
zend_get_closure_invoke_method() but its refcount is not increased.
This caused a crash in the Symfony demo page.
ndossche added a commit that referenced this pull request Feb 24, 2025
… to 8.4.4

This regressed in GH-17592.
The function is with its attributes HashTable* is copied in
zend_get_closure_invoke_method() but its refcount is not increased.
This caused a crash in the Symfony demo page.

Closes GH-17880.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants