Skip to content

Fix GH-18431: Registering ZIP progress callback twice doesn't work - #18432

Closed
ndossche wants to merge 1 commit into
php:PHP-8.3from
ndossche:fix-18431
Closed

Fix GH-18431: Registering ZIP progress callback twice doesn't work#18432
ndossche wants to merge 1 commit into
php:PHP-8.3from
ndossche:fix-18431

Conversation

@ndossche

@ndossche ndossche commented Apr 26, 2025

Copy link
Copy Markdown
Member

Libzip already cleans up the previous callback, so when that means:

  1. The callback zval being already copied over the previous one causes libzip to clean up the new callback object. This is the root cause.
  2. Our own code to clean the old callback is redundant.

@ndossche ndossche linked an issue Apr 26, 2025 that may be closed by this pull request
Registering ZIP progress callback twice doesn't work #18431
Closed
@ndossche
Fix phpGH-18431: Registering ZIP progress callback twice doesn't work
b76f7e3 
Libzip already cleans up the previous callback, so when that means:
1. The callback zval being already copied over the previous one causes
   libzip to clean up the new callback object. This is the root cause.
2. Our own code to clean the old callback is redundant.
@ndossche ndossche closed this in b066ac0 Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: zip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Registering ZIP progress callback twice doesn't work

2 participants

@ndossche @Girgias