Repository navigation
Conversation
Girgias
approved these changes
Jun 22, 2025
Girgias
left a comment
Member
There was a problem hiding this comment.
Nits, but LGTM and this can crash already so a ValueError is OK
| } | ||
|
|
||
| if (ZSTR_LEN(reqoid) == 0) { | ||
| zend_argument_value_error(2, "cannot be empty"); |
Member
There was a problem hiding this comment.
And use the zend_argument_must_not_be_empty_error helper when merging up
Suggested change
| zend_argument_value_error(2, "cannot be empty"); | |
| zend_argument_value_error(2, "must not be empty"); |
Comment on lines
+8
to
+12
| try { | ||
| ldap_exop($conn,null); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage(), PHP_EOL; | ||
| } |
Member
There was a problem hiding this comment.
Remove this case, as it is covered by the empty string one, and this reduces future churn when passing null becomes a TypeError.
Member
|
I wonder whether there are more of these kinds of shenanigans in ext/ldap |
Member
Probably, considering earlier this cycle I found a bunch of NULL deref bugs just by staring at the code :| |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.