Fix ZEND_STATIC_ASSERT for -std=c++17 - #19175

@psumbera @devnexen static_assert() was added in C++11 so this change breaks compilation with -std=c++98 (e.g. swig/swig#3255). If you're going to use static_assert() with C++, it should only be for C++11 and later.

we did not put guards because php supports now C++11/17 minimum.

honestly, if you have the choice, please drop C++98, std::move avoiding better dangling pointers is really worth the jump and that s not the only benefit ;)

Is that also a requirement when building a third party extension module written in C++? That's the situation where we hit this (rather than when building PHP itself as in the linked issue).

If so, where is this requirement documented?

not documented per say but PHP had updated the C++ build here.

Sadly I don't really have the choice (though personally I tend to agree). SWIG is a tool to generate bindings for various langauges, including PHP, and those bindings are very widely used so we're pretty conservative on raising such requirements.

I can argue for raising it specifically for SWIG/PHP if PHP itself rejects compiling with older C++ versions, though it'd be easier to argue if this requirement were documented properly, and also useful to know how evolves with each PHP version. I'd think documenting this would also be helpful for other users.

yes good point about documenting