Repository navigation
Fix GH-20435: SensitiveParameter doesn't work for named argument passing to variadic parameter - #20436
Closed
ndossche wants to merge 2 commits into
Closed
Fix GH-20435: SensitiveParameter doesn't work for named argument passing to variadic parameter#20436ndossche wants to merge 2 commits into
ndossche wants to merge 2 commits into
Conversation
…assing to variadic parameter
TimWolla
approved these changes
Nov 9, 2025
TimWolla
left a comment
Member
There was a problem hiding this comment.
Side-note: In a follow-up for master I'm going to factor out some of this code.
Yeah, this can / should be object_init_with_constructor() at the very least. 👍
Member
Author
Yeah and I planned on factoring out the attribute lookup for the is_sensitive boolean too. |
ndossche
marked this pull request as ready for review
November 9, 2025 20:02
alexandre-daubois
approved these changes
Nov 10, 2025
arnaud-lb
approved these changes
Nov 10, 2025
| zval *arg; | ||
|
|
||
| bool is_sensitive = false; | ||
| if (call->func->common.fn_flags & ZEND_ACC_VARIADIC) { |
Member
There was a problem hiding this comment.
Nit: I think that's implied by ZEND_CALL_HAS_EXTRA_NAMED_PARAMS: We can't have extra named params on non-variadic functions
Member
Author
There was a problem hiding this comment.
You're correct. zend_handle_named_arg even states this in a comment. I'll adjust to an assert.
arnaud-lb
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Side-note: In a follow-up for master I'm going to factor out some of this code.