Repository navigation
Fix GH-20442: Phar does not respect case-insensitiveness of __halt_compiler() when reading stub - #20445
Closed
ndossche wants to merge 1 commit into
Closed
Fix GH-20442: Phar does not respect case-insensitiveness of __halt_compiler() when reading stub#20445ndossche wants to merge 1 commit into
ndossche wants to merge 1 commit into
Conversation
…_compiler() when reading stub Functions are case insensitive. The flush code already takes this into account by checking for the __halt_compiler() symbol in a case insensitive manner; however the parsing code did not do that yet.
TimWolla
approved these changes
Nov 10, 2025
devnexen
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions are case insensitive. The flush code already takes this into account by checking for the __halt_compiler() symbol in a case insensitive manner; however the parsing code did not do that yet.