Repository navigation
Conversation
…on-disk path Before appending the entry to the Location header, webPhar() terminates the request URI right after the phar's file name. It advanced the pointer by the whole on-disk path length rather than by the file name length, so the terminator landed the length of the phar's directory prefix too far. When the request ends at the file name, that write lands past the end of the request URI buffer. When the URI is longer, which a rewrite callback that routes to the index allows, the terminator lands inside the URI and the redirect keeps part of the requested path. The rest of the function already measures the file name as fname_len - (basename - fname).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drafted with an LLM; I reviewed it myself.