Repository navigation
Update deprecation message for incompatible float to int conversion - #7095
Merged
Merged
Conversation
Member
Author
|
Suggested because |
Ayesh
marked this pull request as ready for review
June 3, 2021 17:42
2 tasks done
Member
|
Thank you! That makes sense to me; @Girgias, what do you think? |
Member
We talked about this on the original PR, so this is good to go on my end. :-) |
nikic
reviewed
Jun 4, 2021
Ayesh
force-pushed
the
message-float-int-deprecation
branch
from
June 6, 2021 12:08
027ea9f to
97cda67
Compare
Updates the deprecation message for implicit incompatible float to int conversion from: ``` Implicit conversion from non-compatible float %.*H to int in %s on line %d ``` to ``` Implicit conversion from float %.*H to int loses precision in %s on line %d ``` Related: php#6661
Ayesh
force-pushed
the
message-float-int-deprecation
branch
from
June 6, 2021 13:11
97cda67 to
03e2399
Compare
nikic
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the deprecation message for implicit incompatible float to int conversion from:
to
Related: #6661