Skip to content

Deprecate dynamic property creation - #7390

Closed
nikic wants to merge 2 commits into
php:masterfrom
nikic:deprecate-dynamic-props
Closed

nikic wants to merge 2 commits into
php:masterfrom
nikic:deprecate-dynamic-props

Conversation

@nikic

@nikic nikic commented Aug 20, 2021 •

Copy link
Copy Markdown
Member

What could possibly go wrong?

RFC: https://wiki.php.net/rfc/deprecate_dynamic_properties

TODO:

  • Finish updating tests.
  • JIT support.

@nikic nikic added the RFC label Aug 20, 2021
@mvorisek

mvorisek commented Oct 3, 2021

Copy link
Copy Markdown
Contributor

What will be the behaviour of isset($o->undefined)?

@bwoebi

bwoebi commented Oct 3, 2021

Copy link
Copy Markdown
Member

@mvorisek According to the code only writes are checked, i.e. isset() will continue returning false here.

@nikic

nikic commented Oct 4, 2021

Copy link
Copy Markdown
Member Author

That's right, isset() will silently return false, as usual.

@nikic

nikic commented Nov 26, 2021

Copy link
Copy Markdown
Member Author

This has been superseded by #7571.

@nikic nikic closed this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants