Repository navigation
Conversation
Unfortunately, libedit is locale based and does not accept UTF-8 input when the C locale is used. This patch switches the default locale to C.UTF-8 instead (if it is available). This makes libedit work and I believe it shouldn't affect behavior of single-byte locale-dependent functions that PHP otherwise uses.
Member
Author
|
It might be possible to undo #7333 as well, not sure if that's a separate problem or not. |
|
@nikic how do you think, will this patch be included in PHP 8.1? |
ramsey
reviewed
Nov 12, 2021
Member
|
What's the status here? Are we good with merging into PHP-8.0, or do we first want to merge into PHP-8.1, and cherry-pick later if there are no issues? |
Member
Author
|
Merging into 8.1 first sounds reasonable to me. |
Member
|
Might be a good idea to ship these fixes with PHP 8.1.1RC1. cc @ramsey, @patrickallaert |
|
The bug is still present in PHP-8.0 |
Member
|
Might be sensible to backport into PHP-8.0 now, given that apparently no issues have been reported so far for PHP-8.1. @diesse, consider to submit a respective pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, libedit is locale based and does not accept UTF-8
input when the C locale is used. This patch switches the default
locale to C.UTF-8 instead (if it is available). This makes libedit
work and I believe it shouldn't affect behavior of single-byte
locale-dependent functions that PHP otherwise uses.