Skip to content

Fix GH-7826: Inconsistent argument name in hash_hmac_file and hash_file - #7828

Closed
cmb69 wants to merge 2 commits into
php:PHP-8.0from
cmb69:cmb/gh7826
Closed

cmb69 wants to merge 2 commits into
php:PHP-8.0from
cmb69:cmb/gh7826

Conversation

@cmb69

@cmb69 cmb69 commented Dec 25, 2021

Copy link
Copy Markdown
Member

Like hash_file(), hash_hmac_file() expects a filename, and not some
string data. Fixing this now, constitutes a (hopefully small) BC break
though.

…_file

Like `hash_file()`, `hash_hmac_file()` expects a filename, and not some
string data.  Fixing this now, constitutes a (hopefully small) BC break
though.
@cmb69 cmb69 linked an issue Dec 25, 2021 that may be closed by this pull request
@cmb69 cmb69 closed this in fd3fc5c Dec 26, 2021
@cmb69
cmb69 deleted the cmb/gh7826 branch December 26, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent argument name in hash-hmac-file and hash-file

2 participants